feat: mtaext-driven route host + self-contained ABAP handler classes#1
Merged
Merged
Conversation
Adopt ARC-1's .mtaext workflow (PR #441): mta.yaml no longer pins a
fixed `host:`, so the deploy service assigns a globally-unique
${default-host} instead of the collision-prone `lisa-<space>` route.
The public URL is now pinned in a gitignored mta-overrides.mtaext (a
tracked .example template is provided), which keeps the lisa-<space>
convention -> lisa-dev. Landscape-specific properties (service path,
BTP destinations) move out of mta.yaml into the extension too.
Adds btp:* npm scripts and documents the workflow.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Inline the JSON/param helpers (escape_json, extract_param, json_obj, json_str, json_bool, json_join) into both ZCL_I18N_SERVICE and ZCL_I18N_SERVICE_CLOUD, and drop ZCL_VSP_UTILS / ZIF_VSP_SERVICE. The interface was unused (each class defines its own ty_response) and the utils class only contributed those six helpers. Users now copy a single file matching their stack — no shared dependencies to import. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related cleanups inspired by ARC-1.
1. BTP deployment —
.mtaextworkflow (ARC-1 PR #441)mta.yamlno longer pins a fixedhost:; the deploy service assigns a globally-unique${default-host}instead of the collision-pronelisa-<space>route.mta-overrides.mtaext(tracked.exampletemplate provided), keeping thelisa-<space>convention →lisa-dev.SAP_I18N_SERVICE_PATH,SAP_BTP_*_DESTINATION) move out ofmta.yamlinto the extension.btp:*npm scripts and documents the workflow indocs_page/btp-deployment.md.2. Self-contained ABAP handler classes
ZCL_I18N_SERVICEandZCL_I18N_SERVICE_CLOUD.ZCL_VSP_UTILS(only contributed 6 helpers) andZIF_VSP_SERVICE(unused — each class defines its ownty_response).Verification
mbt build -e mta-overrides.mtaextsucceeds;host/properties resolve inmtad.yaml.🤖 Generated with Claude Code