fix(pdf): add 'pdfjs' element and restore native iframe PDF viewer#2916
Open
Allaoua9 wants to merge 3 commits into
Open
fix(pdf): add 'pdfjs' element and restore native iframe PDF viewer#2916Allaoua9 wants to merge 3 commits into
Allaoua9 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/src/components/chat/Messages/Message/Content/InlinedElements/InlinedPDFjsList.tsx">
<violation number="1" location="frontend/src/components/chat/Messages/Message/Content/InlinedElements/InlinedPDFjsList.tsx:13">
P2: Using the array index as the React key makes PDF items unstable across insertions/reorders and can reuse the wrong `PDFjsElement`/`PDFjsViewer` state.</violation>
</file>
<file name="backend/chainlit/element.py">
<violation number="1" location="backend/chainlit/element.py:37">
P2: New `pdfjs` elements are serialized with type/page metadata, but `from_dict()` does not recognize `pdfjs` and falls back to `File`, breaking deserialization round-trips for the new viewer type.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue : #2896