Reviewed and updated MA12070P driver. Added I2S 32-bit word mode#220
Merged
CarlosDerSeher merged 1 commit intoCarlosDerSeher:developfrom May 6, 2026
Merged
Conversation
…uired for this DAC). Co-authored-by: Copilot <copilot@github.com>
Owner
CarlosDerSeher
left a comment
There was a problem hiding this comment.
I'll have to trust you on the actual driver as I don't know the specifics of this DAC. There is only one thing, please see my comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey folks.
Some time ago, I've created a board with Infineon MA12070P DAC: Loud-ESP32-Plus
I finally found some time to try to spin it up with the driver included with snapclient. As it turned out, code was really raw, not compiling at all, and contained multiple DAC specific errros. I did a full review and rewrite, testing different DAC modes and settings. These are the ones I found optimal.
One thing that took me a long time to figure out - this DAC required 32-bit word on I2S in standard mode. I had to update
player.cto change to 32-bit, when this DAC is selected.Other implementations I took as a reference: