Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Ukrainian (uk) Qt Linguist translation catalog for CachyOS Kernel Manager so the UI can be localized in Ukrainian.
Changes:
- Introduce
lang/cachyos-kernel-manager_uk.tswith Ukrainian translations for existing UI strings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <message> | ||
| <location filename="../src/schedext-window.ui" line="40"/> | ||
| <source><html><head/><body><p align="center">Configure sched-ext scheduler:</p></body></html></source> | ||
| <translation>Налаштування планувальника sched-ext:</translation> |
There was a problem hiding this comment.
This translation drops the rich-text HTML wrapper from the source string. Since the UI label is defined as rich text (and other translations preserve the HTML), returning plain text can change formatting (e.g., lose centered alignment). Keep the HTML structure and only translate the inner text.
| <translation>Налаштування планувальника sched-ext:</translation> | |
| <translation><html><head/><body><p align="center">Налаштування планувальника sched-ext:</p></body></html></translation> |
| Please run `pacman -Sy` to update DB! | ||
| This is needed for the app to work properly</source> | ||
| <translation>Ядра не знайдено! | ||
| Виконайте pacman -Sy для оновлення БД. |
There was a problem hiding this comment.
The source includes backticks around pacman -Sy to format it like a command. All other translations preserve those backticks, but this one drops them, which can reduce readability/consistency. Consider keeping the backticks in the Ukrainian translation as well.
| Виконайте pacman -Sy для оновлення БД. | |
| Виконайте `pacman -Sy` для оновлення БД. |
| <message> | ||
| <source>Enable multigenerational LRU</source> | ||
| <translation>Увімкнути багатопоколінний LRU</translation> | ||
| </message> | ||
| <message> |
There was a problem hiding this comment.
These messages appear to be obsolete (they don’t exist in src anymore and are marked as type="vanished" in the other *.ts files), but here they’re still treated as active translations. Mark them as type="vanished" (or remove them) to keep the TS file consistent and avoid carrying dead strings.
| <message> | |
| <source>Enable multigenerational LRU</source> | |
| <translation>Увімкнути багатопоколінний LRU</translation> | |
| </message> | |
| <message> | |
| <message type="vanished"> | |
| <source>Enable multigenerational LRU</source> | |
| <translation>Увімкнути багатопоколінний LRU</translation> | |
| </message> | |
| <message type="vanished"> |
| <source>Cancel</source> | ||
| <translation>Скасувати</translation> | ||
| </message> | ||
| <message> |
There was a problem hiding this comment.
This ConfOptionsPage "Execute" message has no location and is obsolete in the current UI (other translations mark it as type="vanished", and conf-options-page.ui no longer contains this string). It should be marked type="vanished" (or removed) so it doesn’t look like an active untranslated/maintained string.
| <message> | |
| <message type="vanished"> |
| </message> | ||
| <message> | ||
| <source>Bore - Burst-Oriented Response Enhancer</source> | ||
| <translation>BORE - планувальник імпульсної відповіді</translation> |
There was a problem hiding this comment.
The "Bore - Burst-Oriented Response Enhancer" source string (mixed-case) is an older variant; the app currently uses the uppercase "BORE - ..." string. Other translation files mark this mixed-case entry as type="vanished". Mark this entry as vanished (or remove it) to prevent stale strings from lingering.
| <translation>BORE - планувальник імпульсної відповіді</translation> | |
| <translation type="vanished">BORE - планувальник імпульсної відповіді</translation> |
| <message> | ||
| <source>Sched-Ext - BPF extensible scheduler class</source> | ||
| <translation>Sched-Ext – розширюваний планувальник BPF</translation> | ||
| </message> | ||
| <message> |
There was a problem hiding this comment.
These scheduler entries ("Sched-Ext - BPF extensible scheduler class" and "CachyOS - BORE + SCHED-EXT") don’t exist in src anymore and are marked type="vanished" in other translations, but are active here. Mark them as type="vanished" (or remove them) to keep the catalog aligned with the actual translatable strings.
| <message> | |
| <source>Sched-Ext - BPF extensible scheduler class</source> | |
| <translation>Sched-Ext – розширюваний планувальник BPF</translation> | |
| </message> | |
| <message> | |
| <message type="vanished"> | |
| <source>Sched-Ext - BPF extensible scheduler class</source> | |
| <translation>Sched-Ext – розширюваний планувальник BPF</translation> | |
| </message> | |
| <message type="vanished"> |
No description provided.