Skip to content

Remove all boiler plate#112

Open
MatthewZ0823 wants to merge 1 commit into
CSchank:masterfrom
MatthewZ0823:remove-boiler-plate
Open

Remove all boiler plate#112
MatthewZ0823 wants to merge 1 commit into
CSchank:masterfrom
MatthewZ0823:remove-boiler-plate

Conversation

@MatthewZ0823
Copy link
Copy Markdown

Removed all boilerplate from the repository. Also removes all bugs as a nice side effect

Copy link
Copy Markdown
Owner

@CSchank CSchank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I have left a few minor comments, please review them. It seems you need to review the definition of boilerplate.

Comment thread .gitattributes
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is needed to detect something and perform LF normalization.

Comment thread .gitignore
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this file to ignore things we don't want to commit.

Comment thread .travis.yml
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually should switch this to GH Actions. I support deleting this, but please provide the alternative in GH Actions.

Comment thread README.md
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed so you can read it.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed this to do deployment. But we should switch to GH Actions.

Comment thread src/SaveLoad.elm
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to really save or load anymore I suppose.

Comment thread src/SharedModel.elm
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have no things to share stuff, we don't need the shared thing I guess.

Comment thread src/Simulating.elm
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Comment on Exporting.elm.

Comment thread src/Utils.elm
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now no one has electricity, gas, or water!

Comment thread tests/Example.elm
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we have nothing to have an example of!

@MatthewZ0823
Copy link
Copy Markdown
Author

nuh uh

Copy link
Copy Markdown
Owner

@CSchank CSchank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You make a compelling argument. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants