Skip to content

Add support for React 16#163

Merged
sawyerh merged 11 commits into
stagingfrom
sawyerh/react-16
Oct 13, 2017
Merged

Add support for React 16#163
sawyerh merged 11 commits into
stagingfrom
sawyerh/react-16

Conversation

@sawyerh

@sawyerh sawyerh commented Oct 9, 2017

Copy link
Copy Markdown
Contributor

Changed

  • Add support for React 16.x to design-system-core

Internal

  • Fixed invalid heading tag (should have been header) on docs site 🙈
  • Major updates to React and Enzyme, which required updating some tests and changing how we render the docs when server-side rendering is used.

There are still a few things I'm keeping an eye on before merging this in:

@sawyerh sawyerh changed the title [WIP] Add support for React 16 Add support for React 16 Oct 12, 2017
@sawyerh

sawyerh commented Oct 12, 2017

Copy link
Copy Markdown
Contributor Author

This was more painful than I expected, but I believe I've identified all the issues raised by upgrading to Enzyme v3.

@sawyerh sawyerh requested a review from pwolfert October 12, 2017 18:58
@pwolfert

Copy link
Copy Markdown
Contributor

I haven't looked at the code yet, but I've just pulled it and installed the new deps and tried changing one of the examples, and it doesn't seem to do the hot reload like it's supposed to. I'll look at it more later. Tests run fine though. I haven't done the v16 upgrade yet on our other projects, and I'm not looking forward to the enzyme upgrade.

@sawyerh

sawyerh commented Oct 12, 2017

Copy link
Copy Markdown
Contributor Author

it doesn't seem to do the hot reload like it's supposed to

@pwolfert Good catch. Forgot to update the react-hot-loader dependency. This should be fixed now.

I haven't done the v16 upgrade yet on our other projects, and I'm not looking forward to the enzyme upgrade.

Just to clarify, these changes won't require other projects to update right away. You can continue using React 15.

@pwolfert

pwolfert commented Oct 12, 2017

Copy link
Copy Markdown
Contributor

Just to clarify, these changes won't require other projects to update right away. You can continue using React 15.

I know; I just mean that you saying it was harder than you expected makes me slightly afraid of what's coming in my near future.

@pwolfert pwolfert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ⚛️

@sawyerh sawyerh merged commit 8edae2d into staging Oct 13, 2017
@sawyerh sawyerh deleted the sawyerh/react-16 branch October 13, 2017 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants