fix: include spirv platform in clang branch of run_hipcc.cmake#13
Merged
Conversation
HIP_PLATFORM=spirv (chipStar) was falling into the nvcc else-branch, which appended '--compiler-options -fPIC' for shared libraries. clang does not understand this nvcc-specific flag syntax, causing compilation to fail with: clang++: error: no such file or directory: ''-fPIC''
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_hipcc.cmakechecked onlyHIP_PLATFORM == "amd"to enter the clang compiler branch; chipStar setsHIP_PLATFORM=spirv, so it fell into theelse(nvcc) branch--shared -Xcompiler '-fPIC'; when clang receives the quoted''-fPIC''as a positional argument it fails:clang++: error: no such file or directory: ''-fPIC''spirvRoot cause
Reproducer
Found while building SeisSol with chipStar. SeisSol's Device submodule uses
hip_add_library(... SHARED)withHIP_SOURCE_PROPERTY_FORMATset, which routes compilation throughrun_hipcc.cmake. A regression test is included in the companion chipStar PR.Test plan
SHAREDHIP library viahip_add_library()withHIP_SOURCE_PROPERTY_FORMATon chipStar (HIP_PLATFORM=spirv) — should compile without-fPICquoting errorsHIP_PLATFORM=amd) and CUDA (HIP_PLATFORM=nvidia) builds unaffected