Fix emscripten build for emsdk 3.x#554
Open
theMansib wants to merge 1 commit intoCE-Programming:masterfrom
Open
Fix emscripten build for emsdk 3.x#554theMansib wants to merge 1 commit intoCE-Programming:masterfrom
theMansib wants to merge 1 commit intoCE-Programming:masterfrom
Conversation
- Rename EXTRA_EXPORTED_RUNTIME_METHODS to EXPORTED_RUNTIME_METHODS - Add explicit EXPORTED_FUNCTIONS list for all KEEPALIVE symbols - Change .bc object extension to .o (deprecated in modern LLVM) - Add missing gui_handle_reset() (undefined symbol at link time)
Member
|
I'll check it out in a bit, thanks |
Author
|
No probs! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The emscripten build target doesn't compile on emsdk 3.x.
EXTRA_EXPORTED_RUNTIME_METHODSwas renamed toEXPORTED_RUNTIME_METHODS, the.bcobject extension is deprecated in favor of.o, andgui_handle_reset()is missing fromos-emscripten.ccausing an undefined symbol at link time.This adds an explicit
EXPORTED_FUNCTIONSlist for allEMSCRIPTEN_KEEPALIVEsymbols and fixes the above issues. Tested with emsdk 3.1.74.