This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Add proposed status to study groups#8
Open
armooo wants to merge 3 commits intoBostonPython:masterfrom
Open
Conversation
Add statueses to groups and default new groups to have the status of proposed.
Do not list proposed groups to non-admins. Also respond with a 404 to groups that are proposed to non-admins.
Contributor
Author
|
I am going to rebase this on the migration branch and add a migration. |
Member
|
I don't understand why we need a new table. Surely a status column on the group table would be enough? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes adds a StudyGroupStatus model and a FK from StudyGroup. It also hides StudyGroups in the proposed status from normal users.
We don't have a DB migration system setup so you need to drop and recreate the database to pick up the schema changes.