This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Set the initial values of ions properly in direct and file mode transfer#780
Draft
iomaganaris wants to merge 5 commits intomasterfrom
Draft
Set the initial values of ions properly in direct and file mode transfer#780iomaganaris wants to merge 5 commits intomasterfrom
iomaganaris wants to merge 5 commits intomasterfrom
Conversation
dcad3fa to
808a577
Compare
808a577 to
c3ec12d
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue with ion variables initial values not being in set in file mode transfer of data between NEURON and CoreNEURON.
Even if this seems like an issue it doesn't seem to influence the behavior of some of the simulations I've tried.
Fixes #779
How to test this?
It's pretty difficult to test this so bare with me.
Add the following change to this branch:
You can also print the same string in NEURON and compare the results.
Test System