Closed
Conversation
51b436d to
f267313
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR delivers a complete refactor of the NetworkManager subsystem and the NetworkControlWindow, replacing the monolithic lib/network.py with a clean
manager/worker architecture. It also incorporates all changes from PR #168 (hotspot QR code) and PR #178 (hotspot config file persistence), which were never
merged to dev.
scan results, connection outcome, connectivity, hotspot config, and errors. Includes a 5-minute keepalive timer as a safety net for missed D-Bus signals.
rapid NM signal bursts.
ConnectionPriority, etc.
hotspot QR code, update page.
resources.
gating).
NetworkControlWindow.
Motivation
The original lib/network.py (≈1 550 lines) mixed D-Bus I/O, Qt signal emission, threading concerns, and business logic in a single file, making it hard to
test, maintain, and extend. The new architecture separates concerns strictly:
to handle WPA3/Nokia routers.
Tests
Test configuration: pytest.ini, qt_api=pyqt6, asyncio_mode=auto, QT_QPA_PLATFORM=offscreen.
Co-Authors
Co‑author: @Robert0Mart