Respect array dtype in create_ome_zarr_from_array#155
Merged
lorenzocerrone merged 3 commits intoBioVisionCenter:mainfrom Feb 20, 2026
Merged
Respect array dtype in create_ome_zarr_from_array#155lorenzocerrone merged 3 commits intoBioVisionCenter:mainfrom
lorenzocerrone merged 3 commits intoBioVisionCenter:mainfrom
Conversation
Before this commit, OME-Zarr containers created with this function would always get the default dtype uint16.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
lorenzocerrone
approved these changes
Feb 20, 2026
Collaborator
lorenzocerrone
left a comment
lorenzocerrone
left a comment
There was a problem hiding this comment.
thanks for spotting it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, OME-Zarr containers created with this function would always get the default dtype uint16.
I suggest a suitable test be added in addition to ensure this doesn't break in the future.
Checklist before merging
CHANGELOG.md