Fix default version string format#50
Open
scc-tw wants to merge 1 commit into
Open
Conversation
Owner
|
Thank you for your contribution. I've let the CI run and it looks good. However, I am not quite certain if this is actually an issue and if we should really fix it?
There is no rule against this. It seems like even Microsoft themselves do this and it's a perfectly fine practice. Could you elaborate if you ran into any issues regarding this discrepancy, or if this is purely aesthetic? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #49.
WindowsResource::new()currently initializes the string-tableFileVersionandProductVersionfromCARGO_PKG_VERSION, while the fixedFILEVERSIONandPRODUCTVERSIONvalues are generated as Windows four-part versions.For a Cargo version like
1.7.5, that produces:Windows Shell can then report
System.FileVersionas1.7.5.0butSystem.Software.ProductVersionas1.7.5.This change derives the default string-table versions from the same fixed version value, so the defaults are consistent (
1.7.5.0). Explicit user overrides through.set("FileVersion", ...)or.set("ProductVersion", ...)are still honored.Testing