Skip to content

Create empty secret for backward compatibility #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stiidk merged 1 commit into from
Apr 14, 2026
Merged

Create empty secret for backward compatibility #594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions internal/controller/styra/system_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,8 +637,9 @@ func (r *SystemReconciler) reconcileOPASecret(
log.Info("Reconciling OPA secret")

if r.Config.UserCredentialHandler == nil || r.Config.UserCredentialHandler.S3 == nil {
log.Info("No UserCredentialHandler configured, don't create secret")
return ctrl.Result{}, false, nil
//Deprecated: breaking change in later version where no secret will be created
//create empty secret to avoid OPA complaining about missing secret.
log.Info("No UserCredentialHandler configured, empty secret will be created for OPA")
}

reconcileS3CredentialsStart := time.Now()
Expand Down Expand Up @@ -758,6 +759,11 @@ func (r *SystemReconciler) reconcileS3Credentials(
uniqueName string,
secretName string,
) (s3.Credentials, ctrl.Result, error) {
if r.Config.UserCredentialHandler == nil || r.Config.UserCredentialHandler.S3 == nil {
log.Info("No UserCredentialHandler configured, returning empty S3 credentials")
return s3.Credentials{}, ctrl.Result{}, nil
}

s3Credentials := s3.Credentials{}
s3Credentials.Region = r.Config.UserCredentialHandler.S3.Region
s3Credentials.AccessKeyID = fmt.Sprintf("Access-Key-%s-%s", r.Config.UserCredentialHandler.S3.Bucket, uniqueName)
Expand Down
Loading