Fix flaky core plugin live test#46904
Open
pvaneck wants to merge 1 commit into
Open
Conversation
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Stabilizes a flaky live test in the OpenTelemetry tracing plugin by signaling completion of event consumption with a threading.Event instead of relying on a fixed 3-second join, polling for span export, and shifting the starting position back 30 seconds to tolerate clock skew.
Changes:
- Use a
threading.Eventset insideon_event_batchand wait up to 60s for the batch. - Poll up to 10s for finished spans before asserting the expected count.
- Subtract 30s from
datetime.now()to mitigate client/service clock skew.
Show a summary per file
| File | Description |
|---|---|
| sdk/core/azure-core-tracing-opentelemetry/tests/test_eventhubs_live.py | Replaces fixed-timeout join with event signaling, polls for spans, and offsets the receive starting timestamp. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One test in the tracing plugin frequently fails on windows during nightly live test runs. This test was adjusted to make it more reliable.