Skip to content

Fix flaky core plugin live test#46904

Open
pvaneck wants to merge 1 commit into
Azure:mainfrom
pvaneck:core-plugin-test-fix
Open

Fix flaky core plugin live test#46904
pvaneck wants to merge 1 commit into
Azure:mainfrom
pvaneck:core-plugin-test-fix

Conversation

@pvaneck
Copy link
Copy Markdown
Member

@pvaneck pvaneck commented May 14, 2026

One test in the tracing plugin frequently fails on windows during nightly live test runs. This test was adjusted to make it more reliable.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck pvaneck marked this pull request as ready for review May 15, 2026 06:17
Copilot AI review requested due to automatic review settings May 15, 2026 06:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Stabilizes a flaky live test in the OpenTelemetry tracing plugin by signaling completion of event consumption with a threading.Event instead of relying on a fixed 3-second join, polling for span export, and shifting the starting position back 30 seconds to tolerate clock skew.

Changes:

  • Use a threading.Event set inside on_event_batch and wait up to 60s for the batch.
  • Poll up to 10s for finished spans before asserting the expected count.
  • Subtract 30s from datetime.now() to mitigate client/service clock skew.
Show a summary per file
File Description
sdk/core/azure-core-tracing-opentelemetry/tests/test_eventhubs_live.py Replaces fixed-timeout join with event signaling, polls for spans, and offsets the receive starting timestamp.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants