Skip to content

[Network] az network virtual-network-appliance create/update: Add --private-ip-address-version to support private ip address version#33315

Merged
necusjz merged 4 commits into
Azure:devfrom
huiii99:feat/network-va-ipver-bw
May 15, 2026
Merged

[Network] az network virtual-network-appliance create/update: Add --private-ip-address-version to support private ip address version#33315
necusjz merged 4 commits into
Azure:devfrom
huiii99:feat/network-va-ipver-bw

Conversation

@huiii99
Copy link
Copy Markdown
Member

@huiii99 huiii99 commented May 5, 2026

Related command
az network virtual-network-appliance create
az network virtual-network-appliance update

Description
aaz: Azure/aaz#999
resolve: https://github.com/Azure/CLIPS/issues/10

Support private ip address version in virtual network appliance.

Testing Guide
azdev test test_network_virtual_network_appliance_private_ip_address_version

History Notes


This checklist is used to make sure that common guidelines for a pull request are followed.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented May 5, 2026

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.13
️✔️acs
️✔️latest
️✔️3.12
️✔️3.13
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.13
️✔️ams
️✔️latest
️✔️3.12
️✔️3.13
️✔️apim
️✔️latest
️✔️3.12
️✔️3.13
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.13
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️aro
️✔️latest
️✔️3.12
️✔️3.13
️✔️backup
️✔️latest
️✔️3.12
️✔️3.13
️✔️batch
️✔️latest
️✔️3.12
️✔️3.13
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.13
️✔️billing
️✔️latest
️✔️3.12
️✔️3.13
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.13
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.13
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.13
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.13
️✔️config
️✔️latest
️✔️3.12
️✔️3.13
️✔️configure
️✔️latest
️✔️3.12
️✔️3.13
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.13
️✔️container
️✔️latest
️✔️3.12
️✔️3.13
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.13
️✔️core
️✔️latest
️✔️3.12
️✔️3.13
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.13
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.13
️✔️dls
️✔️latest
️✔️3.12
️✔️3.13
️✔️dms
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.13
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.13
️✔️find
️✔️latest
️✔️3.12
️✔️3.13
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.13
️✔️identity
️✔️latest
️✔️3.12
️✔️3.13
️✔️iot
️✔️latest
️✔️3.12
️✔️3.13
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.13
️✔️lab
️✔️latest
️✔️3.12
️✔️3.13
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️maps
️✔️latest
️✔️3.12
️✔️3.13
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.13
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.13
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.13
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.13
️✔️network
️✔️latest
️✔️3.12
️✔️3.13
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.13
️✔️postgresql
️✔️latest
️✔️3.12
️✔️3.13
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.13
️✔️profile
️✔️latest
️✔️3.12
️✔️3.13
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.13
️✔️redis
️✔️latest
️✔️3.12
️✔️3.13
️✔️relay
️✔️latest
️✔️3.12
️✔️3.13
️✔️resource
️✔️latest
️✔️3.12
️✔️3.13
️✔️role
️✔️latest
️✔️3.12
️✔️3.13
️✔️search
️✔️latest
️✔️3.12
️✔️3.13
️✔️security
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.13
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.13
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.13
️✔️sql
️✔️latest
️✔️3.12
️✔️3.13
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.13
️✔️storage
️✔️latest
️✔️3.12
️✔️3.13
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.13
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.13
️✔️util
️✔️latest
️✔️3.12
️✔️3.13
️✔️vm
️✔️latest
️✔️3.12
️✔️3.13

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented May 5, 2026

❌AzureCLI-BreakingChangeTest
❌network
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd network virtual-network-appliance list cmd network virtual-network-appliance list update parameter resource_group: added property required=True please remove property required=True for parameter resource_group of cmd network virtual-network-appliance list
⚠️ 1006 - ParaAdd network virtual-network-appliance create cmd network virtual-network-appliance create added parameter private_ip_address_version
⚠️ 1010 - ParaPropUpdate network virtual-network-appliance create cmd network virtual-network-appliance create update parameter bandwidth_in_gbps: updated property aaz_type from int to float
⚠️ 1010 - ParaPropUpdate network virtual-network-appliance create cmd network virtual-network-appliance create update parameter bandwidth_in_gbps: updated property options from ['--bandwidth-in-gbps'] to ['--bandwidth-gbps', '--bandwidth-in-gbps']
⚠️ 1010 - ParaPropUpdate network virtual-network-appliance create cmd network virtual-network-appliance create update parameter bandwidth_in_gbps: updated property type from int to float
⚠️ 1006 - ParaAdd network virtual-network-appliance update cmd network virtual-network-appliance update added parameter private_ip_address_version
⚠️ 1010 - ParaPropUpdate network virtual-network-appliance update cmd network virtual-network-appliance update update parameter bandwidth_in_gbps: updated property aaz_type from int to float
⚠️ 1010 - ParaPropUpdate network virtual-network-appliance update cmd network virtual-network-appliance update update parameter bandwidth_in_gbps: updated property options from ['--bandwidth-in-gbps'] to ['--bandwidth-gbps', '--bandwidth-in-gbps']
⚠️ 1010 - ParaPropUpdate network virtual-network-appliance update cmd network virtual-network-appliance update update parameter bandwidth_in_gbps: updated property type from int to float

Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:

  • Breaking changes can only be merged during the designated breaking change window
  • A pre-announcement must be released at least one month in advance

For more details on how to introduce breaking changes, refer to the documentation: azure-cli/doc/how_to_introduce_breaking_changes.md

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 5, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@huiii99 huiii99 force-pushed the feat/network-va-ipver-bw branch from bcd3272 to 05527b9 Compare May 13, 2026 03:58
@huiii99 huiii99 marked this pull request as ready for review May 13, 2026 04:43
Copilot AI review requested due to automatic review settings May 13, 2026 04:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the az network virtual-network-appliance command surface (AAZ-generated) to support/reflect --private-ip-address-version and validates the behavior via scenario tests and recordings. It also includes an unrelated change that promotes --disable-peering-route on route tables out of preview.

Changes:

  • Add a new scenario test covering VNA creation with --private-ip-address-version set to IPv4 and DualStack, and validate privateIPAddressVersion in show/list output.
  • Update AAZ-generated VNA show/wait/delete to use Network API version 2025-07-01 and include privateIPAddressVersion (and related schema regeneration changes).
  • Remove the is_preview marker from az network route-table create/update --disable-peering-route.

Reviewed changes

Copilot reviewed 5 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py Adds VNA private IP version scenario test; adjusts route-table disable-peering test preparer args.
src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_virtual_network_appliance.yaml Updates recorded VNA calls to api-version=2025-07-01 for the main VNA resource requests.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_network_appliance/_wait.py Bumps VNA wait API version and regenerates output schema to include privateIPAddressVersion and other common-schema helpers.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_network_appliance/_show.py Bumps VNA show API version and regenerates output schema to include privateIPAddressVersion and other common-schema helpers.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/virtual_network_appliance/_delete.py Bumps VNA delete API version to 2025-07-01.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/route_table/_update.py Removes preview marker for --disable-peering-route.
src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/route_table/_create.py Removes preview marker for --disable-peering-route.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@necusjz necusjz merged commit c1acf31 into Azure:dev May 15, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants