{ACR} az acr replication create/update: Remove --region-endpoint-enabled flag#33173
{ACR} az acr replication create/update: Remove --region-endpoint-enabled flag#33173lizMSFT wants to merge 3 commits into
az acr replication create/update: Remove --region-endpoint-enabled flag#33173Conversation
lizMSFT
requested review from
YanaXu,
bebound,
jiasli,
naga-nandyala,
teresaritorto,
wangzelin007 and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
northtyphoon and
terencet-dev
There was a problem hiding this comment.
Pull request overview
Removes the deprecated --region-endpoint-enabled flag from az acr replication create/update, completing the rename to the clearer --global-endpoint-routing option in the ACR command module.
Changes:
- Update ACR replication create/update implementation to only accept
global_endpoint_routingand map it to the SDK’sregion_endpoint_enabledproperty. - Remove the
region_endpoint_enabledCLI argument definition and its associated linter exclusions. - Update ACR replication scenario tests to use
--global-endpoint-routing.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_commands.py |
Updates scenario tests to use --global-endpoint-routing instead of the removed flag. |
src/azure-cli/azure/cli/command_modules/acr/replication.py |
Removes deprecated parameter plumbing and uses global_endpoint_routing to set region_endpoint_enabled. |
src/azure-cli/azure/cli/command_modules/acr/_params.py |
Removes the region_endpoint_enabled argument and keeps global_endpoint_routing as the sole flag. |
linter_exclusions.yml |
Removes linter exclusions for the deleted parameter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Please note that we release breaking changes only in the breaking change windows (Build and Ignite), so we need wait until that time to merge this PR. |
lizMSFT
force-pushed
the
zoeyli/acr/remove_deprecated_flag
branch
from
23cd41c to
1ef2d12
Compare
|
Thank you @yanzhudd for the comments. We've already announced this breaking change in the https://learn.microsoft.com/en-us/cli/azure/upcoming-breaking-changes?view=azure-cli-latest#acr via the previous PR. This PR removes the breaking change announcement as well. I couldn't find clear guidance on whether the announcement should be removed after the release, but I went ahead and did so here; please let me know if we should keep it instead. Additionally, the breaking change message from the previous PR still indicates the next breaking change release is 2.86.0, so I raised this PR accordingly. Please let me know if there's anything else we need to address. Thanks. |
|
🔔 Routing this PR to @act-observability-squad. |
yanzhudd
changed the title
az acr replication create/update: Remove --region-endpoint-enabled flag
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
lizMSFT
force-pushed
the
zoeyli/acr/remove_deprecated_flag
branch
from
6c03b00 to
bf88c58
Compare
Related command
az acr replication createaz acr replication updateDescription
This is the follow-up PR to #32954 which introduced --global-endpoint-routing and deprecated --region-endpoint-enabled.
This PR completes the breaking change by removing the deprecated
--region-endpoint-enabledflag.Testing Guide
History Notes
[ACR] BREAKING CHANGE:
az acr replication create/update: Remove deprecated--region-endpoint-enabledflag and use--global-endpoint-routinginstead.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.