Decouple typespec-ts from rlc-common#3926
Open
timovv wants to merge 2 commits into
Open
Conversation
Member
|
@JialinHuang803 could you help take a look at this PR? Thanks |
timovv
requested review from
JialinHuang803,
MaryGao,
joheredi and
qiaozha
as code owners
timovv
force-pushed
the
rlc-common-decouple
branch
from
8096de0 to
5a09300
Compare
timovv
force-pushed
the
rlc-common-decouple
branch
from
6b05380 to
5a09300
Compare
- Copy packages/rlc-common/src/ into packages/typespec-ts/src/rlc-common/ - Update all imports from @azure-tools/rlc-common to relative paths - Remove @azure-tools/rlc-common workspace dependency from package.json - Add handlebars as direct dependency (was transitive via rlc-common) - Update test file imports to point to new location
timovv
force-pushed
the
rlc-common-decouple
branch
from
5a09300 to
7e97b7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for move to the TypeSpec repo. This PR removes the dependency
typespec-tshas onrlc-commonso that we don't need to migraterlc-commonto the new repo. Since autorest is going away, there's no point in having a separate rlc-common package.This was achieved by:
typespec-ts/src/rlc-common/typespec-tsto refer to the new subfolder instead of the external packageThis PR makes the migration easier and opens the door for a more thorough refactor/integration of the rlc-common code in the future.