feat: Complete chat history panel integration#44
Open
john-carroll-sw wants to merge 5 commits intoAzure-Samples:mainfrom
Open
feat: Complete chat history panel integration#44john-carroll-sw wants to merge 5 commits intoAzure-Samples:mainfrom
john-carroll-sw wants to merge 5 commits intoAzure-Samples:mainfrom
Conversation
- Added chat history functionality to display transcriptions from both model responses and user inputs. - Modified App.tsx, types.ts, and history-panel.tsx to support the history panel logic. - Updated translation.json for localized strings related to the chat history. This update enhances the user experience by providing a comprehensive view of the conversation history.
Author
|
The screenshot is slightly misleading. The changes I am committing are only for the history panel pieces. I have not committed any UI changes that are for my demo around Starbucks AI Assistant. Apologies for the confusion in advance. I wanted to show the grounding files in the assistant's chat bubbles and this was my only working demo at the moment. |
Author
Collaborator
|
Thanks for the PR! I'd render the 'Show Chat History' button in a smaller one, e.g. |
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
chuwik
reviewed
Nov 1, 2024
- Removed redundant comments in `App.tsx`, `history-panel.tsx`, and `types.ts`. - Optimized date formatting for `history-panel.tsx` with global considerations. - Corrected time duration in `history-panel.tsx` comment to match code. - Improved timestamp handling in `history-panel.tsx` by reusing existing Date object. - Updated `translation.json` to simplify phrases and avoid uppercase. - Enhanced usage and optional parameters for `groundingFiles` in `types.ts`.
… rendering - Use `Intl.DateTimeFormat` to format timestamps according to the user's locale. - Utilize `navigator.language` to determine the user's preferred language. - Ensure that timestamps are displayed in a format familiar to the user based on their language and regional settings. - For a user with the locale set to `en-US` (United States), the timestamp might be formatted as `2:30 PM`. - For a user with the locale set to `fr-FR` (France), the timestamp might be formatted as `14:30`. - Update the current time every second to dynamically show the timestamp after 60 seconds have passed. - Use `React.memo` to prevent unnecessary re-renders of child components and ensure efficient rendering logic. This change improves the user experience by providing localized timestamp formatting and optimizing component rendering.
Author
|
this is nice feature. i wanted to pull it upon merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This update enhances the user experience by providing a comprehensive view of the conversation history.