fix: scope session idempotency dedupe to tenant/user/session boundary#9
Open
NeerajCodz wants to merge 1 commit into
Open
fix: scope session idempotency dedupe to tenant/user/session boundary#9NeerajCodz wants to merge 1 commit into
NeerajCodz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TestMemoryStore::append_session_messagededuplicated solely byidempotency_key, allowing a caller in one tenant/user/session to suppress messages in other scopes and causing cross-tenant integrity/availability issues.tenant_id,user_id, andsession_idalong withidempotency_key.Description
TestMemoryStore::append_session_messageinsrc/testkit/mod.rsto check the tuple(tenant_id, user_id, session_id, idempotency_key)when deciding whether to treat a message as a duplicate instead of checking onlyidempotency_keyglobally.session_idempotency_is_scoped_per_tenant_user_sessioninsrc/lib.rsthat appends two messages with the same idempotency key in different tenant/user/session scopes and asserts both are retained.Testing
cargo test -qand all tests passed, including the newsession_idempotency_is_scoped_per_tenant_user_sessionregression test.Codex Task