fix: scope postgres memory and reminder identity by tenant#7
Open
NeerajCodz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
nextral_memories.idas a globalPRIMARY KEYandnextral_remindersreferenced memories and dedupe keys globally, enabling cross-tenant ID collisions and overwrite or denial-of-service.Description
migrations/postgres/0001_core_schema.sqlto makenextral_memoriesuse a composite primary keyPRIMARY KEY (tenant_id, id)while preserving theidcolumn.nextral_remindersto reference memories with a tenant-scoped foreign keyFOREIGN KEY (tenant_id, source_memory_id) REFERENCES nextral_memories(tenant_id, id).UNIQUE (tenant_id, dedupe_key), keeping other columns and semantics unchanged.Testing
cargo test) were run previously during validation and passed; the change is a schema-only migration and did not break the test suite.Codex Task