fix: prevent false forget receipts and redaction resurrection#5
Open
NeerajCodz wants to merge 1 commit into
Open
fix: prevent false forget receipts and redaction resurrection#5NeerajCodz wants to merge 1 commit into
NeerajCodz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
forget_memorypath reported successful receipts for derivative backends it never touched, which could mislead callers into believing redaction/deletion had been propagated.consolidate_sessionflow re-ingested full session transcripts with a deterministic ID, allowing previously redacted or soft-deleted memories to be resurrected as active plaintext records.rust-best-practicesskill to ensure changes are minimal and idiomatic.Description
forget_memoryinsrc/runtime/governance.rsto keep the canonicalpostgresreceipt asokbut mark derivative backend receipts (qdrant,neo4j,redis,s3) withstatus: "not_implemented"so the API no longer falsely claims propagation.consolidate_sessioninsrc/runtime/consolidation.rsto compute the deterministic consolidationmemory_idbefore ingestion andreturn Err(CoreError::InvalidInput)if an existing memory with that ID exists and itsstatusis notActive, preventing re-creation of forgotten/redacted memories.src/runtime/governance.rsandsrc/runtime/consolidation.rsand preserve existing behavior where applicable while removing misleading receipts and blocking unsafe re-ingestion.Testing
cargo test -p nextral --lib --quietand all library tests passed (11passed,0failed).Codex Task