fix: enforce tenant/privacy scope in remote adapters#3
Open
NeerajCodz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TenantUserScopeandprivacy_scopecarried by the port APIs, enabling cross-tenant and out-of-scope access or deletion.rust-best-practicesskill was used to shape a minimal, idiomatic remediation that enforces scope checks.Description
QdrantAdapter::searchnow adds aprivacy_levelmatch to the Qdrant filter and binds it torequest.privacy_scopeso returned vector hits are constrained by the requested privacy levels.Neo4jAdapternow scopes graph traversal and redaction to bothtenant_idanduser_idby includingtenant_idin the MATCH and relationship patterns and by passingtenant_idin Cypher parameters.S3Adapter::tombstone_objectnow requires the providedobject_keyto start withtenants/{tenant_id}/and returnsInvalidInputif it does not, preventing cross-tenant deletions; the method now uses thetenant_idparameter rather than ignoring it.Testing
cargo fmt --allto apply repository formatting rules and the command completed successfully.cargo test --liband the test suite completed successfully (11unit tests passed,0failed).Codex Task