Implement PostgreSQL and Redis adapters with Docker memory tests#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new skill,
rust-best-practices, which provides comprehensive guidelines and quick references for writing idiomatic, performant, and robust Rust code. The changes include the creation of a main skill file summarizing best practices, as well as detailed reference chapters covering linting, performance, and error handling.The most important changes are:
Skill Introduction and Overview
.agents/skills/rust-best-practices/SKILL.md, a skill definition file that summarizes idiomatic Rust practices, including borrowing vs cloning, error handling, performance, testing, generics, type state pattern, and documentation standards. It also links to detailed reference chapters for in-depth guidance.Linting and Clippy Best Practices
chapter_02.mddetailing how to use Clippy for linting, important lints to respect, workflow integration, and workspace/package lint configuration. Emphasizes fixing warnings and using#[expect(...)]with justification instead of#[allow(...)].Performance Optimization
chapter_03.mdfocused on performance mindset, including benchmarking, profiling with flamegraph, avoiding redundant cloning, stack vs heap allocation strategies, and efficient use of iterators and zero-cost abstractions.Error Handling Patterns
chapter_04.mdexplaining robust error handling in Rust: preferringResultover panics, when to useunwrap/expect, leveragingthiserrorfor libraries andanyhowfor binaries, error propagation with?, and best practices for testing and async error types.