Skip to content

build on platforms#44

Merged
Araq merged 14 commits intoAraq:masterfrom
ringabout:pr_master_all
Apr 16, 2026
Merged

build on platforms#44
Araq merged 14 commits intoAraq:masterfrom
ringabout:pr_master_all

Conversation

@ringabout
Copy link
Copy Markdown
Contributor

No description provided.

ringabout and others added 3 commits April 14, 2026 16:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 16, 2026 11:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions CI workflow to build the project across the three main GitHub-hosted runners (Linux, Windows, macOS), aligning with the goal of “build on platforms”.

Changes:

  • Introduces a new CI workflow triggered on push and pull_request.
  • Runs a matrix build on ubuntu-latest, windows-latest, and macos-latest.
  • Sets up Nim, installs Linux-specific dependencies, and runs a Nimble command.
Comments suppressed due to low confidence (2)

.github/workflows/ci.yml:22

  • CI installs Nim devel, which makes builds non-deterministic and can introduce sudden breakages unrelated to this repo. Consider pinning to a stable Nim version (or testing both stable + devel via a version matrix) so CI results are reproducible.
        uses: alaviss/setup-nim@0.1.1
        with:
          version: devel
          path: 'nim'

.github/workflows/ci.yml:16

  • actions/checkout@v6 is not a valid released version and will cause the workflow to fail to resolve the action. Pin to an existing major (e.g., actions/checkout@v4) or to a specific commit SHA for supply-chain safety.
      - name: Checkout
        uses: actions/checkout@v6


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml Outdated
@ringabout ringabout mentioned this pull request Apr 16, 2026
Comment thread .github/workflows/ci.yml Outdated
@ringabout
Copy link
Copy Markdown
Contributor Author

Error:  Nim Output /home/runner/work/nimedit/nimedit/app/styles.nim(77, 3) Error: undeclared identifier: 'quitRequest'
        ... candidates (edit distance, scope distance); see '--spellSuggest': 
        ...  (5, 4): 'QuitEvent'
       Tip: 57 messages have been suppressed, use --verbose to show them.
vnext.nim(1128)          buildFromDir

@Araq
Copy link
Copy Markdown
Owner

Araq commented Apr 16, 2026

Has been renamed to shutdown

@Araq Araq merged commit bc1d0c1 into Araq:master Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants