feat: Check if MoCap marker cutoff freq is too low#151
Draft
divyaksh-chander wants to merge 1 commit intoammr4-betafrom
Draft
feat: Check if MoCap marker cutoff freq is too low#151divyaksh-chander wants to merge 1 commit intoammr4-betafrom
divyaksh-chander wants to merge 1 commit intoammr4-betafrom
Conversation
…n raw marker data and filtered marker data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check in the marker driver class template that compares the position of raw marker data and filtered marker data. A large error indicates that cut off frequency is too low.
A warning will be given to the user indicating the marker and the max error for the marker in the entire motion.
However, the warning can also be raised for issues in marker labelling, for example marker flipping, drop out.
To do: