842 feature request update and expand the mqtt messaging system to be properly connected to the events happening in server and send messages to the clients parts 1 3#860
Conversation
…t-messaging-system-to-be-properly-connected-to-the-events-happening-in-server-and-send-messages-to-the-clients-parts-1-3
CapoMK25
left a comment
There was a problem hiding this comment.
I've walked through most of this PR and it looks good. I won't approve it yet as I haven't seen the full picture yet.
|
In many places in the code There are 59 commits in total. I should have made PR after issue 842's part 1, the jukebox & voting part to avoid to one PR to have too much changes. |
…t-messaging-system-to-be-properly-connected-to-the-events-happening-in-server-and-send-messages-to-the-clients-parts-1-3
|
While developing, info about voting and MQTT was added to the |
Brief description
Issue 842's features 1-3 implemented. Merge conflicts solved locally.
There seemed to be merge conflicts only in 1 file and that was a test file:
addVote.ts.I decided to try to merge this into dev before there is more changes.
Change list
Documentation:
Short documentation to jukebox (more detailed in the repo):
The published topics are:
Where:
{clanId}is the unique ID of the player's clan.And short documentation to voting (more detailed in the repo):
Frontend clients that need all voting updates for one clan should subscribe to:
The published topic is:
Where:
{clanId}isvoting.organizer.clan_id{votingType}is one value fromVotingType{status}is one ofnew,update,endCurrent voting types:
flea_market_sell_itemflea_market_buy_itemchange_item_priceshop_buy_itemset_clan_roleclan_governance_updateAll voting notifications use this payload shape:
payload.topicis a voting-instance identifier for the frontend. It is not theMQTT broker topic. The MQTT broker topic remains
/clan/{clanId}/voting/{votingType}/{status}.Short documentation to daily tasks:
I think, it's good to get this to be tested in practice, before making even more changes.