fix: use --tvs-source-path for neighbourhood viewsheds#65
Open
tombh wants to merge 1 commit into
Open
Conversation
Previously it was just using the DEM itself as the source.
ryan-berger
reviewed
Jun 7, 2026
| .only_save_biggest_viewsheds | ||
| .context("Must specify --only-save-biggest-viewsheds")?; | ||
| let dataset = gdal::Dataset::open(&config.input)?; | ||
| let tvs_source_path = config |
Member
There was a problem hiding this comment.
I'm a bit confused here.... Can you have both a --input and a --tvs_source_path?
Collaborator
Author
There was a problem hiding this comment.
Yes. --input is for the raw elevation data, --tvs-source-path is for providing a heatmap so that the neighbourhood culling algorithm can select the best viewsheds.
| let dataset = gdal::Dataset::open(&config.input)?; | ||
| let tvs_source_path = config | ||
| .tvs_source_path | ||
| .clone() |
Member
There was a problem hiding this comment.
Does .clone() do some sort of path validation?
Collaborator
Author
There was a problem hiding this comment.
I think the clone is just prevent a partial borrow of config.
ryan-berger
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it was just using the DEM itself as the source.