TPC-time-series: dynamic track-types#2141
TPC-time-series: dynamic track-types#2141sawenzel wants to merge 1 commit intoAliceO2Group:masterfrom
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
@shahor02, @miranov25 : This should make the TPC time series task react on a disabled TOF detector. However, the workflow then actually crashes: It still searches for TOF. Could you maybe take a look when you have moment? |
sawenzel
changed the title
|
@matthias-kleiner, could you please review this Pull Request from @sawenzel? It appears to be a technical fix for the performance generator module and should not impact standard data taking or physics workflows. Thank you for checking! Best, |
| timeseries_clustertypes=cleanDetectorInputList("FT0,TOF,TPC") | ||
| TPCTStask = createTask(name='tpctimeseries_'+str(tf), needs=tpctsneeds, tf=tf, cwd=timeframeworkdir, lab=["RECO"], mem='2000', cpu='1') | ||
| TPCTStask['cmd'] = 'o2-global-track-cluster-reader --disable-mc --cluster-types "FT0,TOF,TPC" --track-types "ITS,TPC,ITS-TPC,ITS-TPC-TOF,ITS-TPC-TRD-TOF"' | ||
| TPCTStask['cmd'] = f'o2-global-track-cluster-reader --disable-mc --cluster-types {timeseries_clustertypes} --track-types {timeseries_tracktypes}' |
There was a problem hiding this comment.
It initialises unconditionally the readers for TOF clusters and tracks, in the absence of TOF this should lead to a crash. The timeseries_tracktypes and timeseries_clustertypes should not have contributions from detectors which are absent. Also the o2-tpc-time-series-workflow currently implicitly expects all track types it can digest, the same --track-types {timeseries_tracktypes} should be passed to it.
But why are the inputs of this workflow not simply copied from the anchor production workflow?
@matthias-kleiner, in the long run it would be better to modify the o2-global-track-cluster-reader to do what all other global workflows do: configure its input readers internally according to requested options, unless --disable-root-input is requested, e.g. https://github.com/AliceO2Group/AliceO2/blob/166180af16ecac7fa234714cdd7ae0394ea5a192/Detectors/GlobalTrackingWorkflow/src/SecondaryVertexingSpec.cxx#L246-L273
There was a problem hiding this comment.
Hello @shahor02 ,
many thanks for the detailed comment. I will take a look into it.
4 participants
No description provided.