[ALICE3] Further developments for TRK#15262
Open
scannito wants to merge 6 commits intoAliceO2Group:devfrom
Open
[ALICE3] Further developments for TRK#15262scannito wants to merge 6 commits intoAliceO2Group:devfrom
scannito wants to merge 6 commits intoAliceO2Group:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ALICE3 TRK segmented geometry implementation to support staggered/tilted stave placement and to compute more accurate “logical” container volumes so ROOT overlap checks behave reliably.
Changes:
- Extend segmented layer APIs to carry tilt angle and (for ML) stagger offset + configurable stave count.
- Update ML/OT layer volume construction to use analytically computed bounding radii instead of a fixed logical thickness.
- Update
Detectorsegmented configuration (hardcoded and file-driven) to pass the new geometry parameters.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx |
Implements flipped chip placement, new bounding-radii logic, staggered ML placement, and new ctor signatures. |
Detectors/Upgrades/ALICE3/TRK/simulation/src/Detector.cxx |
Updates segmented configuration and parsing to provide tilt/stave/stagger parameters. |
Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/TRKLayer.h |
Updates layer class interfaces/members for new segmented parameters and bounding-radii overrides. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Error while checking build/O2/fullCI_slc9 for f220c7c at 2026-04-11 04:00: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: