Skip to content

Added TypeScript type definitions#24

Open
liamjones wants to merge 1 commit into
Ajackster:masterfrom
living-with:master
Open

Added TypeScript type definitions#24
liamjones wants to merge 1 commit into
Ajackster:masterfrom
living-with:master

Conversation

@liamjones

@liamjones liamjones commented May 26, 2020

Copy link
Copy Markdown

Also available via @types/react-native-global-props.

@remnantdotdev

Copy link
Copy Markdown

Would love to have this merged :)

@fredericoamsb

Copy link
Copy Markdown

Merge this pls :)

@vimaire

vimaire commented Sep 2, 2020

Copy link
Copy Markdown

Hi, having done the work, how about you submit it to the https://github.com/DefinitelyTyped/DefinitelyTyped repository ?
this way, anyone will be able to install the type definitions

@nhbravo

nhbravo commented Oct 20, 2020

Copy link
Copy Markdown

It would be cool to see this merged 👍

@liamjones

Copy link
Copy Markdown
Author

Wow, did I really raise this back in May? Time flies in lockdown...

@vimaire Good idea, I'll see if I can find time to do this soon.

@SHRIRAM0509

Copy link
Copy Markdown

Please merge this :)

@TuNguyenThanh

Copy link
Copy Markdown

@nhbravo

nhbravo commented Dec 24, 2020

Copy link
Copy Markdown

Please merge this :)

@nhbravo

nhbravo commented Feb 17, 2021

Copy link
Copy Markdown

Updates?

@liamjones

Copy link
Copy Markdown
Author

Apologies for the delay. As suggested by @vimaire, I've (finally) raised a PR for this to be added to DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#51462

If anyone interested in helping to progress the merge on DT then reviewing the PR over there would help.

@liamjones

Copy link
Copy Markdown
Author

@types/react-native-global-props has now been merged and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants