Improved command data structure & handler#529
Merged
bitterpanda63 merged 30 commits intomainfrom Dec 8, 2025
Merged
Conversation
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| }, | ||
| connection_manager.timeout_in_sec, | ||
| ) | ||
| event = {"type": "started"} |
There was a problem hiding this comment.
Function on_start no longer fails fast when connection_manager.token is missing; the prior early-return was removed, reducing clarity of control flow
Details
🔧 How do I fix it?
Place parameter validation and guard clauses at the function start. Use early returns to reduce nesting levels and improve readability.
More info - Comment @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
bitterpanda63
changed the title
bitterpanda63
commented
Dec 8, 2025
bitterpanda63
commented
Dec 8, 2025
bitterpanda63
commented
Dec 8, 2025
hansott
approved these changes
Dec 8, 2025
Member
hansott
left a comment
hansott
left a comment
There was a problem hiding this comment.
We went over the PR in a huddle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.