Fix: Replace incorrect Fibonacci logic with proper Binary Search#1
Open
ASATOV-GLITCH wants to merge 2 commits intoAhmet321S:mainfrom
Open
Fix: Replace incorrect Fibonacci logic with proper Binary Search#1ASATOV-GLITCH wants to merge 2 commits intoAhmet321S:mainfrom
ASATOV-GLITCH wants to merge 2 commits intoAhmet321S:mainfrom
Conversation
Ahmet321S
force-pushed
the
main
branch
28 times, most recently
from
7143baf to
805d958
Compare
Ahmet321S
force-pushed
the
main
branch
30 times, most recently
from
4a3d235 to
c95dbce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I was checking out the project and noticed that the code in binary-search.py was actually about the Fibonacci sequence, not binary search. I thought it was a bit confusing for a learning playground, so I decided to fix it. I’ve replaced it with a proper binary search and used a safer way to calculate the midpoint to avoid any issues with large numbers. Hope this helps!