feat: add trajectory-level batching, loss aggregation, and dynamic batching support#85
Open
lqzxt wants to merge 2 commits intoAgentR1:mainfrom
Open
feat: add trajectory-level batching, loss aggregation, and dynamic batching support#85lqzxt wants to merge 2 commits intoAgentR1:mainfrom
lqzxt wants to merge 2 commits intoAgentR1:mainfrom
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces trajectory-aware training support by batching samples at the trajectory level, aggregating loss across entire trajectories, and adding dynamic batching to better handle variable-length trajectories. These changes ensure that all multi-turn completions from the same trajectory are processed within the same forward/backward pass while improving training efficiency and reducing memory fragmentation.
Changes