feat(go-sdk): deduplicate tool_calling, add ToolCallResult wrapper, PromptConfig, system prompt support, and tool name sanitization#483
Open
Luffy2208 wants to merge 3 commits intoAgent-Field:mainfrom
Conversation
Contributor
Performance
✓ No regressions detected |
Contributor
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
Contributor
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
Contributor
Author
|
Working on test coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the Go SDK tool-calling loop to improve code quality, remove duplication, and align behavior with Python and TypeScript SDKs. This PR introduces structured abstractions, configurable prompts, system prompt support, and tool name sanitization while preserving backward compatibility.
Key Changes
1. Deduplicated Capability Conversion
ReasonerCapabilityandSkillCapabilitycapabilityToTool(...)normalizeToolParameters(...)CapabilityToToolDefinitionto delegate to helper functions2. Added ToolCallResult Wrapper (API Parity)
.Text()helper for convenienceExecuteToolCallLoopResult(...)ExecuteToolCallLoop(...)3. Introduced PromptConfig (Removed Hardcoded Strings)
DefaultPromptConfig()resolvePromptConfig(...)4. Added System Prompt Support
ToolCallConfig:5. Added Tool Name Sanitization
sanitizeToolName(...)unsanitizeToolName(...)6. Refactored Tool-Calling Loop
buildToolCallRequest(...)loopMessageseffectiveOpts7. Added encodeToolContent Helper
8. Improved Default Configuration
DefaultToolCallConfig()to initializePromptConfig9. Updated agent.go for Compatibility
:-based tool names to.format before execution10. Expanded Test Coverage
Added tests for:
Testing
./scripts/test-all.shgo test ./...successfullygo vet ./...successfullyChecklist
CHANGELOG.md(or this change does not warrant a changelog entry).Screenshots (if UI-related)
Not applicable
Related Issues
Fixes #234