Remove unit_metadata hack#1127
Merged
Nadrieril merged 3 commits intoAeneasVerif:mainfrom May 7, 2026
Merged
Conversation
All this to avoid adding a variant in the output of `simplify_constants`... Not worth it.
Nadrieril
force-pushed
the
remove-unit-metadata
branch
from
4bc42e4 to
769431f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hack was added because back then aeneas didn't support some
ConstantExprKindvariants and it felt cleaner not to expand that. Time has taught me that this was a mistake.ci: use AeneasVerif/eurydice#402
ci: use AeneasVerif/aeneas#985