feat: add a node for char values#1121
Open
clementblaudeau wants to merge 3 commits intoAeneasVerif:mainfrom
Open
feat: add a node for char values#1121clementblaudeau wants to merge 3 commits intoAeneasVerif:mainfrom
clementblaudeau wants to merge 3 commits intoAeneasVerif:mainfrom
Conversation
Member
|
On the Rust side this change does not make sense. Could you make this change only on the ocaml side without affecting the Rust side? You should just special case chars in the ocaml generator |
Author
|
Ok, I'll revert the changes on the rust ast side and only affect the ml generator then |
Instead of changing the shape of the rust ast, the ml-generation is changed to patch the ast with an extra node for chars just before the actual generation of ml definitions.
Author
|
I've updated the patch : now the rust ast is untouched, but during ml-generation an extra node for chars is added. The fixes are partially Claude generated, partially hand-written. |
Nadrieril
reviewed
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a wrapper around char values. It is used by AeneasVerif/aeneas#917. In Aeneas, it allows handling char values without exposing the internal representation as a
UChar.t