V3 workflow update#57
Conversation
Withdrawing naming suggestions — pr-validation and pr-comment are consistent with each other and follow a common convention.
There was a problem hiding this comment.
Couple of changes needed before this is ready:
Add the deploy.yml fork guard to this PR. commerce-testing #186 added github.repository_owner == 'AdobeDocs' to the deployment job's if:, but deploy.yml isn't in this PR. The update-bot syncs deploy.yml from dev-docs-template@main, so the guard needs to live here or every commerce repo gets the un-guarded version. One-line change on deploy.yml#30:Retracted — #57 (comment)
if: github.repository_owner == 'AdobeDocs' && github.actor != 'adp-devsite-app[bot]' && github.repository != 'AdobeDocs/dev-docs-template'
2. Branch protection. This deletes lint.yml + post-lint-comment.yml. If the commerce repos have Lint as a required check, PRs will sit pending forever once it stops reporting. Can you add a note to the v3 update announcement telling repo owners to swap their required checks from Lint → PR validation / PR Comment?
|
Not sure adding |
|
And thanks for the branch protection, since this v3 update involves a deletion action to lint.yml, I'm imaging that once lint.yml is removed, the lint branch protection rule should go away maybe? |
I don't think it auto-updates — per GitHub's docs, branch protection matches required checks by name (Lint), not by file. So deleting |
Ah good point — then this PR's good for the commerce rollout. I did file DEVSITE-2467 for the deploy job showing green when it's effectively skipped (a cancelled/grey state would be a clearer signal it didn't actually run) |
This is a update for version 3 workflow for all default content repos. By centralizing the lint and post-lint-report workflows, these ymls can be removed from content repo and no longer needed to be maintained by content repo authors.