pablo and ruber package by ReinaldoAguilar · Pull Request #29 · AT-03/coding

ReinaldoAguilar · 2017-07-07T00:32:42Z

No description provided.

codecov-io · 2017-07-07T00:36:15Z

Codecov Report

Merging #29 into develop will increase coverage by 0.95%.
The diff coverage is 97.84%.

@@              Coverage Diff              @@
##             develop      #29      +/-   ##
=============================================
+ Coverage      94.78%   95.73%   +0.95%     
- Complexity       138      202      +64     
=============================================
  Files             26       41      +15     
  Lines            307      446     +139     
  Branches          50       59       +9     
=============================================
+ Hits             291      427     +136     
- Misses             5        7       +2     
- Partials          11       12       +1

Impacted Files	Coverage Δ	Complexity Δ
...fundacionjala/coding/reinaldo/movies/Customer.java	`100% <100%> (ø)`	`7 <7> (?)`
...fundacionjala/coding/reinaldo/movies/Children.java	`100% <100%> (ø)`	`4 <4> (?)`
...ndacionjala/coding/reinaldo/kataBankOcr/Digit.java	`100% <100%> (ø)`	`1 <1> (?)`
...ng/reinaldo/multiplesOf3And5/MultiplesOf3And5.java	`100% <100%> (ø)`	`5 <5> (?)`
...einaldo/highestAndLowestTest/HighestAndLowest.java	`100% <100%> (ø)`	`2 <2> (?)`
...ndacionjala/coding/reinaldo/movies/NewRelease.java	`100% <100%> (ø)`	`4 <4> (?)`
...ionjala/coding/reinaldo/evaporator/Evaporator.java	`100% <100%> (ø)`	`3 <3> (?)`
...njala/coding/reinaldo/kataBankOcr/BankOcrKata.java	`100% <100%> (ø)`	`9 <9> (?)`
.../fundacionjala/coding/reinaldo/movies/Regular.java	`100% <100%> (ø)`	`4 <4> (?)`
...g/fundacionjala/coding/reinaldo/movies/Rental.java	`100% <100%> (ø)`	`4 <4> (?)`
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112c303...ade5ef3. Read the comment docs.

carledriss · 2017-07-07T01:10:27Z

src/main/java/org/fundacionjala/coding/reinaldo/kataBankOcr/FileNumberBankOcr.java

@AT-03/at-03
what is wrong here?

carledriss · 2017-07-07T01:10:48Z

src/main/java/org/fundacionjala/coding/reinaldo/kataBankOcr/HistoryOneBankOcr.java

we don't need inheritance here.

carledriss · 2017-07-07T01:11:18Z

src/main/java/org/fundacionjala/coding/reinaldo/kataBankOcr/HistoryTwoChecksum.java

why are you using Spanish?

carledriss · 2017-07-07T01:11:33Z

src/main/java/org/fundacionjala/coding/reinaldo/movies/Children.java

carledriss · 2017-07-07T01:12:18Z

src/main/java/org/fundacionjala/coding/reinaldo/movies/Children.java

+     * {@inherentDoc}
+     *
+     * @param daysRented Int with daysRented for Children movie.
+     */


This should be

/** * {@inherentDoc} */

carledriss · 2017-07-07T01:12:42Z

src/main/java/org/fundacionjala/coding/reinaldo/movies/Customer.java

@AT-03/at-03
what is wrong here?

carledriss · 2017-07-07T01:13:44Z

src/test/java/org/fundacionjala/coding/reinaldo/kataBankOcr/BankOcrTest.java

Move it to a @before method

carledriss · 2017-07-07T01:13:53Z

src/test/java/org/fundacionjala/coding/reinaldo/kataBankOcr/BankOcrTest.java

it should be final

ReinaldoAguilar · 2017-07-09T08:11:17Z

@carledriss

carledriss · 2017-07-11T23:40:45Z

src/main/java/org/fundacionjala/coding/reinaldo/kataBankOcr/EncodedDigit.java

instead of doing this
please convert a constant the Map
static final

carledriss · 2017-07-11T23:41:07Z

src/main/java/org/fundacionjala/coding/reinaldo/multiplesOf3And5/MultiplesOf3And5.java

NUMBERDIVISOR ?
NUMBERDIVISORCINCO ?

ReinaldoAguilar · 2017-07-12T12:00:18Z

@carledriss thanks for your observation.

pablo and ruber package

d4b7952