Add unit tests for train_rl.get_rollout_kwargs_for_parallelism#3377
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 11, 2026
Merged
Add unit tests for train_rl.get_rollout_kwargs_for_parallelism#3377copybara-service[bot] merged 1 commit intomainfrom
train_rl.get_rollout_kwargs_for_parallelism#3377copybara-service[bot] merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🤖 Hi @igorts-git, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 Hi @igorts-git, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
This PR successfully adds clear and targeted unit tests for the train_rl.get_rollout_kwargs_for_parallelism function, improving test coverage for the RL testing fixit. The tests are logically structured and effectively cover both successful auto-derivation cases and common error scenarios.
🔍 General Feedback
- Good Use of Mocks: The usage of
SimpleNamespaceto mocksampler_configis clean and minimizes setup overhead for the tests. - Clear Assertions: Utilizing
assertRaisesRegexfor error testing effectively ensures that the correct validation branches are being triggered. - Test Structure: The test cases are well-documented with descriptive docstrings and comments, making the intent of each test immediately understandable.
c3bbec3 to
b4f14da
Compare
hengtaoguo
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is part of the RL testing Fixit.
It adds a few simple unit tests to the
train_rl.get_rollout_kwargs_for_parallelismfunction.FIXES: b/490410802, b/490410719, b/490411080, b/490410543
Pair-programmed with Gemini-CLI.
Tests
This PR is a collection of new unit tests. No runtime functionality has been changed.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.