Add support for config flag with no file path#3373
Open
dipannita08 wants to merge 2 commits intomainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bvandermoon
reviewed
Mar 11, 2026
Collaborator
There was a problem hiding this comment.
Thank you @dipannita08. Is it significantly harder to infer the config needed based on the command (like you had mentioned previously) and just pass that directly through?
shralex
requested changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently users need to pass in the file path to config file when running MaxText workloads (
src/maxtext/configs/post_train/rl.yml)This change adds support to resolve or infer the config without requiring the user to specify the config path, while previous functionality is still supported.
FIXES: b/491604657
Tests
configflag:Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.