Skip to content

Add support for config flag with no file path#3373

Open
dipannita08 wants to merge 2 commits intomainfrom
maxtext-rl-uxr-config-flags
Open

Add support for config flag with no file path#3373
dipannita08 wants to merge 2 commits intomainfrom
maxtext-rl-uxr-config-flags

Conversation

@dipannita08
Copy link
Collaborator

@dipannita08 dipannita08 commented Mar 11, 2026

Description

Currently users need to pass in the file path to config file when running MaxText workloads (src/maxtext/configs/post_train/rl.yml)

This change adds support to resolve or infer the config without requiring the user to specify the config path, while previous functionality is still supported.

FIXES: b/491604657

Tests

  • CI
  • Run a workload with config flag:
python3 -m maxtext.trainers.pre_train.train
  run_name=$RUN_NAME \
  base_output_directory=$OUTPUT_PATH \
  dataset_type=synthetic \
  steps=$STEPS
  • Run a workload with full config file path:
python3 -m maxtext.trainers.pre_train.train src/maxtext/configs/base.yml \
  run_name=$RUN_NAME \
  base_output_directory=$OUTPUT_PATH \
  dataset_type=synthetic \
  steps=$STEPS

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dipannita08. Is it significantly harder to infer the config needed based on the command (like you had mentioned previously) and just pass that directly through?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants