Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
This PR successfully implements the DeepSeek V3.2 Indexer training loss within MaxText. The core logic for calculating and propagating the KL divergence loss correctly integrates with the existing MTP and MoE loss aggregation patterns.
🔍 General Feedback
- The
indexer_lossis accumulated and scaled correctly throughtrain.pyand gradient accumulation mechanisms. - Tests thoroughly cover both dense and sparse configurations.
- Be mindful of mask aggregation; applying
attention_maskmultiple times viaindexer_maskcan lead to numerical instability (-infresulting inNaNloss) during softmax operations, which has been highlighted inline.
4fbb511 to
0b401fa
Compare
shuningjin
reviewed
Mar 11, 2026
eceefcb to
ce58515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Indexer training loss for DeepSeek V3.2:
IndextoIndexerto align in MaxTextTests
deepseek32_vs_reference_testsame as main branch (b/491486716)Run cmd
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.