adds gradient accumulation to distillation training via tunix#3361
Open
adds gradient accumulation to distillation training via tunix#3361
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
4a0d45c to
f2d2ec8
Compare
vlad-karp
approved these changes
Mar 10, 2026
gagika
reviewed
Mar 11, 2026
Collaborator
There was a problem hiding this comment.
should this also be updated if gradient_accumulation_steps > 1?
total_opt_steps = student_config.steps // student_config.gradient_accumulation_steps
optimizer = get_distillation_optimizer(student_config, total_opt_steps)
e29ee6a to
b2bbf02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FIXES b/490478748 which enables gradient accumulation to the distillation training script.
Tests
Ran
distillation_checkpointing_testandtrain_distill_test.Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.