Conversation
| - all | ||
| - tpu | ||
| - gpu | ||
| for_dev_test: |
Collaborator
There was a problem hiding this comment.
What is the use case for this?
Collaborator
Author
There was a problem hiding this comment.
This is to keep the images generated by this workflow development tests in another image repo so the formal image repo is not polluted.
(our previous discussion: For testing purposes, can you change the name of the docker image so that it doesn't pollute our production images.)
xibinliu
force-pushed
the
xibin/ci2
branch
2 times, most recently
from
ffd00f3 to
ea56990
Compare
xibinliu
commented
Mar 6, 2026
| context: . | ||
| file: ${{ inputs.dockerfile }} | ||
| tags: gcr.io/tpu-prod-env-multipod/${{ inputs.image_name }}:latest | ||
| tags: gcr.io/tpu-prod-env-multipod/${{ inputs.image_name }}:${{ inputs.image_date }}-build-${{ github.run_id }} |
Collaborator
Author
There was a problem hiding this comment.
@SurbhiJainUSC we need to discuss what tags do we want to add to the images before and after testing.
Current:
- before tests: <image_date>-build-${{ github.run_id }}, hashes of the repos
- after tests: "latest", and "<image_date>"
- images will only be tagged to the current date when unit tests pass - images will only be tagged to "latest" when unit tests pass
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests
See this manually triggered workflow run.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.