Conversation
Migrate artifact names to match nostr-java 2.0 module structure: - nostr-java-api → nostr-java-core - nostr-java-crypto → nostr-java-core - nostr-java-id → nostr-java-identity - nostr-java-encryption → nostr-java-identity - Remove nostr-java-base (merged into core) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace PubKeyTag with GenericTag for tag handling in NsecBunkerAdminClient and RelayContainerIntegrationTest, aligning with the simplified tag API in nostr-java 2.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Projects updated: - nsecbunker-java (parent): 0.1.1 → 0.2.0 (minor) - All 14 submodules: 0.1.1 → 0.2.0 (minor) Changes include: - Upgraded nostr-java from 1.2.0 to 2.0.0 - Migrated to new nostr-java 2.0 module structure - Adapted code to nostr-java 2.0 API (GenericTag) - Created CHANGELOG.md Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deleted unused `.github/pull_request_template.md` and `.github/workflows/release.yml` files to clean up the repository.
There was a problem hiding this comment.
Pull request overview
This PR upgrades the nostr-java dependency from version 1.2.0 to 2.0.0, adapting to the new module structure and API changes introduced in the newer version. The project version is bumped from 0.1.1 to 0.2.0 to reflect this breaking dependency change.
Changes:
- Upgraded nostr-java dependency from 1.2.0 to 2.0.0 across all modules
- Migrated to nostr-java 2.0 module structure (consolidated artifacts)
- Replaced deprecated
PubKeyTagAPI withGenericTagin admin client and integration tests
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated nostr-java version to 2.0.0, consolidated dependency artifacts from 6 to 3 modules |
| nsecbunker-admin/pom.xml | Updated parent version to 0.2.0, migrated to nostr-java-identity and nostr-java-core |
| nsecbunker-admin/src/main/java/xyz/tcheeric/nsecbunker/admin/NsecBunkerAdminClient.java | Replaced PubKeyTag with GenericTag.of() for tag creation and serialization |
| nsecbunker-account/pom.xml | Updated parent version to 0.2.0 |
| nsecbunker-client/pom.xml | Updated parent version to 0.2.0, added nostr-java-core and nostr-java-identity dependencies |
| nsecbunker-connection/pom.xml | Updated parent version to 0.2.0, changed dependency from nostr-java-api to nostr-java-event |
| nsecbunker-core/pom.xml | Updated parent version to 0.2.0, removed nostr-java-api dependency |
| nsecbunker-monitoring/pom.xml | Updated parent version to 0.2.0 |
| nsecbunker-protocol/pom.xml | Updated parent version to 0.2.0, consolidated nostr-java-crypto and nostr-java-encryption into nostr-java-identity |
| nsecbunker-spring-boot-starter/pom.xml | Updated parent version to 0.2.0 |
| nsecbunker-tests/pom.xml | Updated parent version to 0.2.0 |
| nsecbunker-tests/nsecbunker-chaos/pom.xml | Updated parent version to 0.2.0 |
| nsecbunker-tests/nsecbunker-e2e/pom.xml | Updated parent version to 0.2.0, migrated to nostr-java-identity and nostr-java-core |
| nsecbunker-tests/nsecbunker-it/pom.xml | Updated parent version to 0.2.0 |
| nsecbunker-tests/nsecbunker-it/src/test/java/xyz/tcheeric/nsecbunker/it/RelayContainerIntegrationTest.java | Replaced PubKeyTag with GenericTag for event tag serialization in test |
| nsecbunker-tests/nsecbunker-perf/pom.xml | Updated parent version to 0.2.0, migrated to nostr-java-identity and nostr-java-core |
| nsecbunker-tests/nsecbunker-security/pom.xml | Updated parent version to 0.2.0 |
| CHANGELOG.md | Added entry for version 0.2.0 documenting the nostr-java upgrade and API changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate the entire project from nostr-java 1.2.0 to 2.0.0, adapting to the new module structure and API changes. Bumps project version from 0.1.1 to 0.2.0.
Related Issue
N/A
Type of Change
Checklist
Testing
Built successfully with
mvn clean install -DskipTests.Key changes
Dependency migration (nostr-java 1.2.0 → 2.0.0):
nostr-java-api→nostr-java-corenostr-java-crypto→nostr-java-corenostr-java-id→nostr-java-identitynostr-java-encryption→nostr-java-identitynostr-java-base(merged into core)Code adaptation:
PubKeyTagwithGenericTaginNsecBunkerAdminClientandRelayContainerIntegrationTestVersion bump:
Additional Notes
Tagged as
v0.2.0.🤖 Generated with Claude Code