fix some commands sending to server#463
Open
thepoppetmaster1000 wants to merge 5 commits into19MisterX98:masterfrom
Open
fix some commands sending to server#463thepoppetmaster1000 wants to merge 5 commits into19MisterX98:masterfrom
thepoppetmaster1000 wants to merge 5 commits into19MisterX98:masterfrom
Conversation
checks if arguments have executor set, otherwise injects fallback into .executes() using getUsage() method
- also add getUsageType() and getUsageCategory() methods - refactor build() so type and category have own nodes which allows .executes() to be set on each node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
fixes this issue: #459
some commands with subcommands typed without their required arguments were not being handled
by the mod builder, since cant found no executor on those nodes and
forwarded the input to the server
these commands were affected:
/seedcracker version/seedcracker data/seedcracker finder/seedcracker finder type/seedcracker finder category/seedcracker rendersolution:
ClientCommand.register(): afterbuild()is called, if builder has arguments but no executor, one is
automatically injected using
getUsage()and so the resteach affected command overrides
getUsage()to provide a specific usagemessage to show
-also
FinderCommandneeded itstypeandcategorynodesrefactored out of loop so
.executes()can be attached to thenodes themselves
this fits better with the actual code than my last pr
/seedcrackershows invalid command errorthe rest shows a especific message of usage