Skip to content

Fix/slow site#571

Merged
alexanmtz merged 13 commits intoworknenjoy:masterfrom
SavvyShah:fix/slow-site
Mar 28, 2020
Merged

Fix/slow site#571
alexanmtz merged 13 commits intoworknenjoy:masterfrom
SavvyShah:fix/slow-site

Conversation

@SavvyShah
Copy link
Copy Markdown
Contributor

Description

Spliting app.js bundle for better performance and caching.

Changes

  • Moved frontend/public/index.html to frontend/src/index.html
  • Changed webpack config files and server.js

Issue

#450

Impacted Area

Steps to test

Steps needed to reproduce the scenario from this change to validate if the pull request solve this issue

  • You can check in developer menu. The size should have decreased.

Before

Screenshot from the state before

After

Screenshot from the state after your Pull Request

@SavvyShah
Copy link
Copy Markdown
Contributor Author

@alexanmtz please test with the latest changes. This will improve the performance a lot.

@alexanmtz alexanmtz temporarily deployed to gitpay-fix-slow-site-tjrlhxsox March 28, 2020 00:04 Inactive
@alexanmtz alexanmtz temporarily deployed to gitpay-fix-slow-site-as3qsx3no March 28, 2020 00:06 Inactive
Copy link
Copy Markdown
Member

@alexanmtz alexanmtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamCanMakeCommit before we can test in a review environment, we had a minor issue, let's fix this and proceed with the test.

Comment thread frontend/package.json Outdated
"jest": "^23.5.0",
"jest-cli": "^23.6.0",
"jest-webpack": "^0.5.1",
"mini-css-extract-plugin": "^0.9.0",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we try to deploy, Heroku logs the following error:
Cannot find module 'mini-css-extract-plugin'

So I think we cannot move here, cause Heroku use this lib in production.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes. I think your'e correct. Heroku doesn't install dev dependecies that is why all the plugins in our project our installed in package.json

@alexanmtz alexanmtz temporarily deployed to gitpay-fix-slow-site-fnysky6en March 28, 2020 04:48 Inactive
@SavvyShah
Copy link
Copy Markdown
Contributor Author

It just loaded like a zap.!! I think heroku also makes some optimization.
Total Under 700KB.
Material UI under 300KB.
image

@alexanmtz alexanmtz temporarily deployed to gitpay-fix-slow-site-fnysky6en March 28, 2020 05:11 Inactive
@SavvyShah
Copy link
Copy Markdown
Contributor Author

Slack Icon now loads. Commit replaced back.
Total Still Under 900KB.

@alexanmtz alexanmtz merged commit 9e2187f into worknenjoy:master Mar 28, 2020
@alexanmtz
Copy link
Copy Markdown
Member

@SavvyShah, you have a bounty to claim from a long time: https://gitpay.me/#/task/316

Please submit your PR for the Send solution and claim your bounty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants