Skip to content

Should the [all] extra include google-embeddings? #534

@Kh05ifr4nD

Description

@Kh05ifr4nD

In pyproject.toml, google-embeddings is defined as a separate extra:

google-embeddings = [
    "google-generativeai>=0.8.0,<1",
]

But the all extra currently does not include it:

all = [
    "code-review-graph[embeddings]",
    "code-review-graph[communities]",
    "code-review-graph[enrichment]",
    "code-review-graph[eval]",
    "code-review-graph[wiki]",
]

The README, however, documents:

pip install code-review-graph[all]                 # All optional dependencies

Should code-review-graph[all] literally include all optional dependency groups, including google-embeddings? Or is google-embeddings intentionally excluded from all because it is a cloud provider dependency?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions