Commit 25226d3
committed
Simplify dc_is_backed_declared_property()
Per @arnaudlb's review: !(pi->flags & ZEND_ACC_VIRTUAL) already implies
pi->offset == ZEND_VIRTUAL_PROPERTY_OFFSET (they're the same marker on
the property_info side), and IS_HOOKED_PROPERTY_OFFSET() is only
meaningful on offsets returned by zend_get_property_offset() — not on
the raw pi->offset stored in properties_info. The extra checks were
dead code. Collapse to a single bitmask test.1 parent 9072a51 commit 25226d3
1 file changed
+5
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
638 | 638 | | |
639 | 639 | | |
640 | 640 | | |
641 | | - | |
642 | | - | |
643 | | - | |
644 | | - | |
645 | | - | |
646 | | - | |
647 | | - | |
648 | | - | |
649 | | - | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
650 | 646 | | |
651 | 647 | | |
652 | 648 | | |
| |||
0 commit comments