Skip to content

Fix invalid props being passed to <A> #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LadyBluenotes merged 3 commits into from
Feb 5, 2026
+6 −3
Merged

Fix invalid props being passed to <A> #1420

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7be1b22
Fix invalid props being passed to `<A>`
amirhhashemi Feb 5, 2026
4bf5b24
Merge branch 'main' into fix-button-props
kodiakhq[bot] Feb 5, 2026
99fa0c5
Merge branch 'main' into fix-button-props
kodiakhq[bot] Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/ui/button-link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,23 @@
import { splitProps } from "solid-js";
import { A, type RouterLinkProps } from "./i18n-anchor";

type ButtonLinkProps = RouterLinkProps & {
variant: "primary" | "secondary";
};

export const ButtonLink = (props: ButtonLinkProps) => {
const [localProps, otherProps] = splitProps(props, ["variant"]);

return (
<A
addLocale
classList={{
"rounded-full bg-blue-300 py-2 px-4 text-sm font-semibold text-slate-900 hover:bg-blue-200 focus:outline-none focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-blue-300/50 active:bg-blue-500":
props.variant === "primary",
localProps.variant === "primary",
"rounded-full bg-slate-800 py-2 px-4 text-sm font-semibold text-white hover:bg-slate-700 focus:outline-none focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-white/50 active:text-slate-300":
props.variant === "secondary",
localProps.variant === "secondary",
}}
{...props}
{...otherProps}
/>
);
};